[PATCH] tdb and msync

simo idra at samba.org
Wed Sep 3 14:58:30 GMT 2008

I got a report here in Fedora bugzilla[1] about tdb missing to use msync
before a munmap operation.
Checking manpages it seem quite correct. 

I see we had a thread on this named: "changes to .tdb files lost"[2] in
Sept. 2005 where Volker also agrees that using msync() before an
munmap() is helpful.

I am not sure what impact on performances we might get this way,
tdb_munmap() seem to be called in quite a few places, but I guess it is
not used in critical paths anyway. Advice if not.

Please let me know if it is ok to commit this patch in all branches.


[1] https://bugzilla.redhat.com/show_bug.cgi?id=460851
http://lists.samba.org/archive/samba-technical/2005-September/042731.html (unfortunately Volkers reply on our archives seem unreadbale, but you can find it searching other archives on the net).
Simo Sorce
Samba Team GPL Compliance Officer <simo at samba.org>
Senior Software Engineer at Red Hat Inc. <simo at redhat.com>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-The-msync-manpage-reports-that-msync-must-be-calle.patch
Type: application/mbox
Size: 1561 bytes
Desc: not available
Url : http://lists.samba.org/archive/samba-technical/attachments/20080903/178464e6/0001-The-msync-manpage-reports-that-msync-must-be-calle.bin

More information about the samba-technical mailing list