[PATCH] tdb and msync
jra at samba.org
Wed Sep 3 18:03:15 GMT 2008
On Wed, Sep 03, 2008 at 02:58:30PM +0000, simo wrote:
> I got a report here in Fedora bugzilla about tdb missing to use msync
> before a munmap operation.
> Checking manpages it seem quite correct.
> I see we had a thread on this named: "changes to .tdb files lost" in
> Sept. 2005 where Volker also agrees that using msync() before an
> munmap() is helpful.
> I am not sure what impact on performances we might get this way,
> tdb_munmap() seem to be called in quite a few places, but I guess it is
> not used in critical paths anyway. Advice if not.
> Please let me know if it is ok to commit this patch in all branches.
Patch looks good to me. I'd say commit. We don't really have
a choice as data loss is the only alternative.
More information about the samba-technical