[Samba] missing msdfs referrals from samba directory listing: wrong order in smbd_dirptr_get_entry()?

Michael Tokarev mjt at tls.msk.ru
Fri Jun 7 04:59:04 UTC 2024

07.06.2024 07:54, Jeremy Allison wrote:
>> msdfs is broken in 4.19.  It worked fine in 4.18.

This is not entirely true.

>> Is no one using msdfs?  I wonder why I was the first to discover this?
> There must not be a test for your specific use-case.
> MSDFS is tested in the autobuild test suite. Can
> you articulate the problem well enough we can
> build a regression test for it, and then we
> can ensure it never gets broken for this case
> again.

I hoped this is obvious even from the subject line :)

with 4.19, msdfs reparse points are missing from the directory *listing*
from samba.  When specifying the msdfs name directly, samba uses it fine -
and this is covered by the tests.  But there's no test which checks the
msdfs entry in the file *listing* generated by samba.

With my question above - "is no one using msdfs?" - I'm not sure it is
worth the effort to actually fix this for 4.19.  Maybe it is if the fix
would be simple.


GPG Key transition (from rsa2048 to rsa4096) since 2024-04-24.
New key: rsa4096/61AD3D98ECDF2C8E  9D8B E14E 3F2A 9DD7 9199  28F1 61AD 3D98 ECDF 2C8E
Old key: rsa2048/457CE0A0804465C5  6EE1 95D1 886E 8FFB 810D  4324 457C E0A0 8044 65C5
Transition statement: http://www.corpit.ru/mjt/gpg-transition-2024.txt

More information about the samba mailing list