[Samba] missing msdfs referrals from samba directory listing: wrong order in smbd_dirptr_get_entry()?

[Jeremy Allison]

On Fri, Jun 07, 2024 at 07:16:06AM +0300, Michael Tokarev via samba wrote:
>06.06.2024 19:33, Michael Tokarev via samba wrote:
>
>>For quite some time I'm trying to find what's going on with MSDFS referrals.
>>Samba version is 4.19.6.
>..
>>However, when opening the directory in question from client, this name is not
>>shown in the listing.  Samba skips this name from the listing when looping over
>>readdir entries:
>
>So, the same config just works in samba-4.20.  There has been a quite few changes in
>this area in 4.20, but the order of checks in smbd_dirptr_get_entry() didn't actually
>change (but the code is different), -- looks like the change happened in smbd_dirptr_get_entry
>itself.
>
>msdfs is broken in 4.19.  It worked fine in 4.18.
>
>Is no one using msdfs?  I wonder why I was the first to discover this?

There must not be a test for your specific use-case.

MSDFS is tested in the autobuild test suite. Can
you articulate the problem well enough we can
build a regression test for it, and then we
can ensure it never gets broken for this case
again.

Sorry for the trouble.

Jeremy.