[Samba] Problem after update version 4.15.0

[Ingo Asche]

Hi Andrew,

you're quite welcome...

As I'm in IT the guy who's normally keep the systems running this is a 
little "adventure" for me.

Before I try this I have one question. As I already started the bisect 
over and done the next two versions (commits?) I got the following results:

commit 997fbcbc902d945eb5261ddc6667f830fbcd5931 (HEAD)
4.15.0pre1-GIT-997fbcbc902
Login failed (The one we aleady know)

commit 12ba3d9d8f2e480d92da16831e09af0d16709724 (HEAD)
4.15.0pre1-GIT-12ba3d9d8f2
Login works

commit 845a59919e528d083b1ab025844c41155ac93e43 (HEAD)
4.15.0pre1-GIT-845a59919e5
Login works

What does that say? Should I go further? I just try to understand 
this... :-)

Regards
Ingo

Andrew Bartlett via samba schrieb am 17.10.2021 um 23:08:
> Thanks so much.  Ideally 'git
> revert 997fbcbc902d945eb5261ddc6667f830fbcd5931' on origin/master or
> origin/v4-15-test would restore the previous behaviour, but it is also
> quite likely to do something else entirely.
>
> That is because with previous (to an extent, if not individually
> tested) and subsequent development (GD's patches are a series, lots of
> other changes along with this specific change) would rely on that
> commit and so the revert produces a new previously unintended
> codepath.
>
> You could look over the whole series and work revert it all, that
> command would be:
>
> git checkout origin/master && git revert e168a95c1bb1928cf206baf6d2db851c85f65fa9..5ecda3bc3fbf899602a7e953d7c424f6435577d5 --no-edit && make -j
>
> It would be an interesting data point if that worked or didn't, but
> from here really we just need to wait for some of GD's developer time
> to look into it.  Of course you can continue using 4.14 in your
> production.
>
> I thank you deeply for all the time you have put into this, it is
> really valuable to dig into this so diligently.
>
> Andrew Bartlett
>
> On Sun, 2021-10-17 at 15:17 +0200, Ingo Asche via samba wrote:
>> Ok, I started the git bisect over and it stops working at the same
>> point:
>>
>> commit 997fbcbc902d945eb5261ddc6667f830fbcd5931 (HEAD)
>> 4.15.0pre1-GIT-997fbcbc902
>>
>> I will try at least the next two or three ones to see if something
>> changes.
>>
>> That leaves the question why the revert didn't worked. Maybe I did
>> something wrong. To be sure what would be the correct procedure
>> again?
>>
>> Regards
>> Ingo
>>
>>