Beta4 SWAT Global error (PR#12023)

Jeremy Allison jallison at cthulhu.engr.sgi.com
Tue Dec 15 20:18:12 GMT 1998


misdavi at rohmhaas.com wrote:
> 
> ACK!  I lost most of the global settings in SWAT in BETA 4.  I don't see
> the Workgroup options etc.  All I see is three lines for security.  The
> options aren't in the aadvanced view either.  I even tried putting back
> the default smb.conf and still didn't see it.
> 
> Thanks,
> Robert Davis
> 

Bug that got in at the last minute I'm afraid. Here's the
patch for beta4 ...


+++ web/swat.c  Tue Dec 15 11:54:19 1998
@@ -254,8 +254,10 @@
                        continue;
                }
                if (parm->flags & FLAG_HIDE) continue;
-               if (printers & !(parm->flags & FLAG_PRINT)) continue;
-               if (!printers & !(parm->flags & FLAG_SHARE)) continue;
+               if (snum >= 0) {
+                       if (printers & !(parm->flags & FLAG_PRINT)) continue;
+                       if (!printers & !(parm->flags & FLAG_SHARE)) continue;
+               }
                if (!advanced) {
                        if (!(parm->flags & FLAG_BASIC)) {
                                void *ptr = parm->ptr;

Sorry about that.

	Jeremy Allison,
	Samba Team.

-- 
--------------------------------------------------------
Buying an operating system without source is like buying
a self-assembly Space Shuttle with no instructions.
--------------------------------------------------------


More information about the samba mailing list