[PATCH] Fix string to integer conversion

Jeremy Allison jra at samba.org
Fri Jan 25 17:54:57 UTC 2019

On Fri, Jan 25, 2019 at 06:45:39PM +0100, swen wrote:
> => I did that 

I'm OK with that :-).

> > 2) Setting errno=0 inside VFS code is fraught with
> > danger. Your changes indirectly do this by changing
> > conv_str_size() to set errno to zero as a side effect
> > which is called by some of the VFS functions.
> => I handled that exactly as you suggested by saving
>    the original errno value and restoring it again 
>    after strtoull got dealed with.
> The only thing the 2 of us couldn't get a common opinion on
> is how a possible wrapper for the above could look like.
> Regarding that you said in another mail.

Yep, and that's why I'm going NAK on this.
I showed you the right way to do this, even
wrote the wrapper for you, and you decided
to ignore that advice. That's your perogative of
course, but while you do, I'm going to NAK.

> > I am not the ultimate gatekeeper on this, if you
> > can find 2 other Samba Team engineers to agree
> > with you, you can override my veto.
> ... and I thought, that's what I'm trying to do here.

Sure, if 2 other engineers say "well I'm OK with
this", then my veto is overwritten. But I need
to add my veto every time you post this so that
they know I have objections to this.

> Did I misunderstand something ?

Nope, this is the process. If Team members want
to override a NAK, they need to know there's a
NAK and why.


More information about the samba-technical mailing list