[PATCH] Fix string to integer conversion
swen at linux.ibm.com
Fri Jan 25 18:20:12 UTC 2019
On Fri, 2019-01-25 at 09:54 -0800, Jeremy Allison wrote:
> On Fri, Jan 25, 2019 at 06:45:39PM +0100, swen wrote:
> > => I did that
> I'm OK with that :-).
> > > 2) Setting errno=0 inside VFS code is fraught with
> > > danger. Your changes indirectly do this by changing
> > > conv_str_size() to set errno to zero as a side effect
> > > which is called by some of the VFS functions.
> > => I handled that exactly as you suggested by saving
> > the original errno value and restoring it again
> > after strtoull got dealed with.
> > The only thing the 2 of us couldn't get a common opinion on
> > is how a possible wrapper for the above could look like.
> > Regarding that you said in another mail.
> Yep, and that's why I'm going NAK on this.
> I showed you the right way to do this, even
> wrote the wrapper for you, and you decided
> to ignore that advice.
Hmmm, not sure if this is worded ... really fair !?
> > > I am not the ultimate gatekeeper on this, if you
> > > can find 2 other Samba Team engineers to agree
> > > with you, you can override my veto.
> > ... and I thought, that's what I'm trying to do here.
> Sure, if 2 other engineers say "well I'm OK with
> this", then my veto is overwritten. But I need
> to add my veto every time you post this so that
> they know I have objections to this.
> > Did I misunderstand something ?
> Nope, this is the process. If Team members want
> to override a NAK, they need to know there's a
> NAK and why.
I interpreted your position on this a bit more passive I guess
as in "I won't support but won't block either".
As it stands I would have needed 2 supporters anyway,
with or without your NAK, therefore I was a bit surprised by
you emphasizing it.
The chances were small to get it in.
But now, I'm afraid, they're pretty much zero.
Anyhow, as we both stated already, not important enough to bikeshed.
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 833 bytes
Desc: This is a digitally signed message part
More information about the samba-technical