[PATCH] Fix string to integer conversion

swen swen at linux.ibm.com
Fri Jan 25 17:45:39 UTC 2019

On Fri, 2019-01-25 at 08:59 -0800, Jeremy Allison wrote:
> On Fri, Jan 25, 2019 at 09:30:02AM +0100, swen via samba-technical
> wrote:
> > All
> > 
> > There's a merge request for this small patch-set on gitlab
> > https://gitlab.com/samba-team/samba/merge_requests/197
> > with all tests passed !
> > 
> > Just in case someone prefers to look at it seperatly 
> > please have a look at the attachment.
> > 
> > Please review and push if happy.
> NAK on this patch for the reasons you and I already
> discussed. You haven't addressed any of them and I
> will continue to object to this until you do.

this is the modified first version of the patchset to which
you commented

> 1) nttime_from_string() is actually an unused function.
>    ...
>    Rather than fix, just delete it !

=> I did that 

> 2) Setting errno=0 inside VFS code is fraught with
> danger. Your changes indirectly do this by changing
> conv_str_size() to set errno to zero as a side effect
> which is called by some of the VFS functions.

=> I handled that exactly as you suggested by saving
   the original errno value and restoring it again 
   after strtoull got dealed with.

The only thing the 2 of us couldn't get a common opinion on
is how a possible wrapper for the above could look like.
Regarding that you said in another mail.

> I am not the ultimate gatekeeper on this, if you
> can find 2 other Samba Team engineers to agree
> with you, you can override my veto.

... and I thought, that's what I'm trying to do here.

Did I misunderstand something ?

Cheers Swen

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: This is a digitally signed message part
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20190125/f91c11d2/signature.sig>

More information about the samba-technical mailing list