[PATCH] s4:heimdal_build: fix --nonshared-binary=smbpasswd failure by rep_closefrom

Stefan Metzmacher metze at samba.org
Thu Apr 11 20:29:33 UTC 2019

Hi Jones,

> This patch fix --nonshared-binary=smbpasswd failure by rep_closefrom,
> looks like 3a7ebd0e940e80b185a9240c093e1fee6795fd5b introduced it from
> samba-4.9.0 and later,
> please help review and push, thank you.
> logs:
> [1727/1727] Linking default/source3/utils/smbpasswd
> default/source4/heimdal/lib/roken/closefrom_1.o: In function
> `rep_closefrom':
> closefrom.c:(.text+0x0): multiple definition of `rep_closefrom'
> default/lib/replace/closefrom_2.o:closefrom.c:(.text+0x26f): first defined
> here
> collect2: error: ld returned 1 exit status

Can you check if removing this from source4/heimdal_build/wscript_build
also fixes the problem:

    if not bld.CONFIG_SET('HAVE_CLOSEFROM'):
        ROKEN_HOSTCC_SOURCE += '''


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20190411/10b7390e/signature.sig>

More information about the samba-technical mailing list