[PATCH] s4:heimdal_build: fix --nonshared-binary=smbpasswd failure by rep_closefrom

Jones Syue jonessyue at qnap.com
Thu Apr 11 09:58:48 UTC 2019


Hello list,

This patch fix --nonshared-binary=smbpasswd failure by rep_closefrom,
looks like 3a7ebd0e940e80b185a9240c093e1fee6795fd5b introduced it from
samba-4.9.0 and later,
please help review and push, thank you.

logs:
[1727/1727] Linking default/source3/utils/smbpasswd
default/source4/heimdal/lib/roken/closefrom_1.o: In function
`rep_closefrom':
closefrom.c:(.text+0x0): multiple definition of `rep_closefrom'
default/lib/replace/closefrom_2.o:closefrom.c:(.text+0x26f): first defined
here
collect2: error: ld returned 1 exit status

build steps:
./configure --without-ad-dc --without-json --without-libarchive
--without-acl-support --without-ldap --without-ads --without-pam
--nonshared-binary="smbpasswd"; \
make smbpasswd

build failed:
samba-4.10.2
samba-4.10.0
samba-4.9.6
samba-4.9.0

build passed:
samba-4.8.11

--
Regards,
Jones Syue | 薛懷宗
QNAP Systems, Inc.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-s4-heimdal_build-fix-nonshared-binary-smbpasswd-fail.patch
Type: application/octet-stream
Size: 1346 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20190411/64d9503a/0001-s4-heimdal_build-fix-nonshared-binary-smbpasswd-fail.obj>


More information about the samba-technical mailing list