[RFC PATCH v2 2/3] s3: net: implement json output for ads info

[Philipp Gesang]

Hi Andrew,

thank you for the feedback!

-<| Quoting Andrew Bartlett <abartlet at samba.org>, on Tuesday, 2018-07-10 08:52:12 AM |>-
> On Tue, 2018-07-10 at 08:28 +1200, Andrew Bartlett via samba-technical
> wrote:
> > On Mon, 2018-07-09 at 11:08 +0200, Philipp Gesang via samba-technical
> > wrote:
> > > The output differs from that of plain 'info' in that times are
> > > not formatted as timestamps.
> > 
> > Why is that (given we have utility functions for that)?

time_t is simpler to handle at the other end than a formatted
timestamp.

> > Also, we really should have a test.  
> > 
> > Sadly this will reopen the can of worms around which configure options
> > would require json, in this case the combination of --enable-seftest
> > but not --without-ads would start to need json.  
> > 
> > See lib/audit_logging/wscript and the attached patch.
> > 
> > However you need to adapt the configure options to explain this is no
> > longer just for audit.

Are there any plans for moving the JSON wrappers out of the audit
/ audit context? Right now one needs to link against
“common_auth” and include “audit_logging.h” to access the JSON
functionality which is somewhat unintuitive.

> > Attached is my first attempt, please build on that.
> > 
> > CI: https://gitlab.com/catalyst-samba/samba/pipelines/25428061
> 
> Also, please sign up to gitlab and do CI via that.  It will ensure you
> don't break supported combinations while adding this and so make review
> easier. 
> 
> https://wiki.samba.org/index.php/Samba_CI_on_gitlab

Will do.

Best,
Philipp
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20180710/23b984ee/signature.sig>