[RFC PATCH v2 2/3] s3: net: implement json output for ads info

Andrew Bartlett abartlet at samba.org
Mon Jul 9 20:52:12 UTC 2018

On Tue, 2018-07-10 at 08:28 +1200, Andrew Bartlett via samba-technical
> On Mon, 2018-07-09 at 11:08 +0200, Philipp Gesang via samba-technical
> wrote:
> > Add the switch '-j' to 'net' to format the output as JSON.
> > 
> > The rationale is to supply the information in a machine-readable
> > fashion to complement the text version of the output which is
> > neither particularly well defined nor locale-safe.
> A good use for JSON output.
> > The output differs from that of plain 'info' in that times are
> > not formatted as timestamps.
> Why is that (given we have utility functions for that)?
> Also, we really should have a test.  
> Sadly this will reopen the can of worms around which configure options
> would require json, in this case the combination of --enable-seftest
> but not --without-ads would start to need json.  
> See lib/audit_logging/wscript and the attached patch.
> However you need to adapt the configure options to explain this is no
> longer just for audit.
> Attached is my first attempt, please build on that.
> CI: https://gitlab.com/catalyst-samba/samba/pipelines/25428061


Also, please sign up to gitlab and do CI via that.  It will ensure you
don't break supported combinations while adding this and so make review



Andrew Bartlett
Andrew Bartlett                       http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba

More information about the samba-technical mailing list