[RFC PATCH v2 2/3] s3: net: implement json output for ads info

Philipp Gesang philipp.gesang at intra2net.com
Thu Jul 12 06:31:53 UTC 2018

-<| Quoting Philipp Gesang <philipp.gesang at intra2net.com>, on Tuesday, 2018-07-10 09:20:24 AM |>-
> > > Attached is my first attempt, please build on that.
> > > 
> > > CI: https://gitlab.com/catalyst-samba/samba/pipelines/25428061

See here: https://gitlab.com/phgsng/samba/commits/i2n-net-ads-json

Your branch diverged from the error code one so I had to
reconcile the two first (commit 7dc72313b9).

> > Also, please sign up to gitlab and do CI via that.  It will ensure you
> > don't break supported combinations while adding this and so make review
> > easier. 
> > 
> > https://wiki.samba.org/index.php/Samba_CI_on_gitlab

Miraculously, the CI worked as soon as I forked you repo. It
passes now: https://gitlab.com/phgsng/samba/pipelines/25588751

How do you wish me to proceed: send a merge request against your
repo on Gitlab or resubmit it here as patches?


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20180712/d7aab62e/signature.sig>

More information about the samba-technical mailing list