[PATCH] make flapping smbcontrol test more informative

Jeremy Allison jra at samba.org
Fri Feb 23 17:08:13 UTC 2018

On Fri, Feb 23, 2018 at 02:07:40PM +1300, Douglas Bagnall via samba-technical wrote:
> One of the recent flapping tests is:
> 2 UNEXPECTED(error):
> samba.tests.blackbox.smbcontrol.samba.tests.blackbox.smbcontrol.SmbcontrolBlockboxTests.test_ping(fl2003dc:local)
> This is a canary, I suspect -- the test itself is sound (sort of), and
> smbcontrol is working, but in trying to ping every server that should
> be pingable, the test finds failed servers before something else does.
> The trouble is that it tells us nothing about what went wrong, only
> that a ping against a PID failed. These patches make the failure
> contain just a tiny clue about what happened.
> Douglas

Thanks Douglas, RB+ and pushed, as this just stopped my
last autobuild :-).


More information about the samba-technical mailing list