[PATCH] make flapping smbcontrol test more informative

Douglas Bagnall douglas.bagnall at catalyst.net.nz
Fri Feb 23 01:07:40 UTC 2018


One of the recent flapping tests is:

2 UNEXPECTED(error):
samba.tests.blackbox.smbcontrol.samba.tests.blackbox.smbcontrol.SmbcontrolBlockboxTests.test_ping(fl2003dc:local)

This is a canary, I suspect -- the test itself is sound (sort of), and
smbcontrol is working, but in trying to ping every server that should
be pingable, the test finds failed servers before something else does.

The trouble is that it tells us nothing about what went wrong, only
that a ping against a PID failed. These patches make the failure
contain just a tiny clue about what happened.

Douglas
-------------- next part --------------
A non-text attachment was scrubbed...
Name: blackbox-messgae.patch
Type: text/x-patch
Size: 3578 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20180223/b9510147/blackbox-messgae.bin>


More information about the samba-technical mailing list