[PATCH] make flapping smbcontrol test more informative
douglas.bagnall at catalyst.net.nz
Sun Feb 25 06:43:10 UTC 2018
On 24/02/18 06:08, Jeremy Allison wrote:
> On Fri, Feb 23, 2018 at 02:07:40PM +1300, Douglas Bagnall via samba-technical wrote:
>> One of the recent flapping tests is:
>> 2 UNEXPECTED(error):
>> This is a canary, I suspect -- the test itself is sound (sort of), and
>> smbcontrol is working, but in trying to ping every server that should
>> be pingable, the test finds failed servers before something else does.
>> The trouble is that it tells us nothing about what went wrong, only
>> that a ping against a PID failed. These patches make the failure
>> contain just a tiny clue about what happened.
> Thanks Douglas, RB+ and pushed, as this just stopped my
> last autobuild :-).
... and as soon as it lands in master:
BlackboxProcessError: Command 'bin/smbcontrol 2692415 ping'; exit status 1; stdout: ''; stderr: ''; message: trying to ping ldap_server
I wish I was more surprised.
More information about the samba-technical