[PATCH] samba-tool group list

Douglas Bagnall douglas.bagnall at catalyst.net.nz
Wed Feb 21 21:46:40 UTC 2018

On 22/02/18 10:28, Rowland Penny via samba-technical wrote:

>> As to *why*: it isn't just about showing that the patch works now, it
>> is about ensuring nobody makes a change in the future that stops it
>> working.
> I can understand that Samba needs tests, but does it needs so many ??
> It wasn't that long ago that autobuild seemed to be in total failure.
> My personal opinion (for what it is worth) is that the test setup at
> present is too complex, is written in too many languages and fails all
> too readily.

Fair enough. That is why I would prefer you to stick with the existing
language test infrastructure and language for samba-tool. Having some of
the group tests in the python harness and some in a shell script
somewhere does not simplify the situation.

> I also think my proposed change is so small it probably
> doesn't really need a test, but as I said, I will write one.

Thank you!


More information about the samba-technical mailing list