[PATCH] samba-tool group list

Rowland Penny rpenny at samba.org
Wed Feb 21 21:28:57 UTC 2018

On Thu, 22 Feb 2018 09:44:37 +1300
Douglas Bagnall <douglas.bagnall at catalyst.net.nz> wrote:

> Hi Rowland,
> >> Naturally it will need a test before it is merged, but I want to
> >> understand the use case a little more as well.
> > 
> > Oh give over, this is just a switch on an existing samba-tool
> > command, it doesn't (in my opinion) need a test. It doesn't change
> > anything in AD, it just reads what is already there, but in a
> > slightly different way. Just how do you test that ??? 
> You could add a method to python/samba/tests/samba_tool/group.py and
> add groups as necessary that you'd expect to be listed or not listed,
> then make sure you get the results you expect.

OK, you can have a test, but it will not be in
python/samba/tests/samba_tool/group.py, it will be a sh script. I
personally think it is is silly to test samba-tool with more python,
nobody will use it in that way, they will type the command into a
terminal, a sh script is the nearest thing to a terminal

> As to *why*: it isn't just about showing that the patch works now, it
> is about ensuring nobody makes a change in the future that stops it
> working.

I can understand that Samba needs tests, but does it needs so many ??
It wasn't that long ago that autobuild seemed to be in total failure.
My personal opinion (for what it is worth) is that the test setup at
present is too complex, is written in too many languages and fails all
too readily. I also think my proposed change is so small it probably
doesn't really need a test, but as I said, I will write one.


More information about the samba-technical mailing list