[PATCH] libcli/smb: Parse primary domain from session setup

Stefan Metzmacher metze at samba.org
Mon Oct 30 07:58:18 UTC 2017

Am 30.10.2017 um 03:58 schrieb Andrew Bartlett:
> On Tue, 2017-10-24 at 10:56 +1300, Andrew Bartlett via samba-technical
> wrote:
>> On Mon, 2017-10-23 at 14:12 +0200, Samuel Cabrero via samba-technical
>> wrote:
>>> Hi,
>>> I still have this patch on the queue, I sent it some time ago.
>> This looks good to me.  Could we have a test so we don't break this
>> again?
> Any chance you can write a test for this?
>> Also, please file a bug for backport.
>> Metze: Can I get some more comment from you on this?  You made
>> comments
>> about some of the parsing routines working only by luck here:
>> https://bugzilla.samba.org/show_bug.cgi?id=12824
>> Was there an intentional reason this support was lost?
> Can I please get a comment on this patch from the broader team?

[MS-SMB] Server Response Extensions lists only NativeLanMan
and NativeOS.

But it seems Samba sends the workgroup. Does some other servers also
do this?


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: OpenPGP digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20171030/08f0f37a/signature.sig>

More information about the samba-technical mailing list