[PATCH] libcli/smb: Parse primary domain from session setup

[Samuel Cabrero]

I have tested Windows server 2008 R2 and 2012 R2 and none of them send
the workgroup, but samba does.

To put some context the goal of the patch is to fix the "net rap server
domain" command, which uses the primary domain from session setup to
call NetServerEnum2. If Windows does not send it I can add an optional
argument to the command to specify the workgroup, this would be
compatible with the submitted patch.


On Mon, 2017-10-30 at 08:58 +0100, Stefan Metzmacher via samba-
technical wrote:
> Am 30.10.2017 um 03:58 schrieb Andrew Bartlett:
> > On Tue, 2017-10-24 at 10:56 +1300, Andrew Bartlett via samba-
> > technical
> > wrote:
> > > On Mon, 2017-10-23 at 14:12 +0200, Samuel Cabrero via samba-
> > > technical
> > > wrote:
> > > > Hi,
> > > > 
> > > > I still have this patch on the queue, I sent it some time ago.
> > > 
> > > This looks good to me.  Could we have a test so we don't break
> > > this
> > > again?
> > 
> > Any chance you can write a test for this?
> > 
> > > Also, please file a bug for backport.
> > > 
> > > Metze: Can I get some more comment from you on this?  You made
> > > comments
> > > about some of the parsing routines working only by luck here:
> > > https://bugzilla.samba.org/show_bug.cgi?id=12824
> > > 
> > > Was there an intentional reason this support was lost?
> > 
> > Can I please get a comment on this patch from the broader team?
> 
> [MS-SMB] 2.2.4.6.2 Server Response Extensions lists only NativeLanMan
> and NativeOS.
> 
> But it seems Samba sends the workgroup. Does some other servers also
> do this?
> 
> metze
>