[PATCH] libcli/smb: Parse primary domain from session setup

Andrew Bartlett abartlet at samba.org
Mon Oct 30 02:58:41 UTC 2017

On Tue, 2017-10-24 at 10:56 +1300, Andrew Bartlett via samba-technical
> On Mon, 2017-10-23 at 14:12 +0200, Samuel Cabrero via samba-technical
> wrote:
> > Hi,
> > 
> > I still have this patch on the queue, I sent it some time ago.
> This looks good to me.  Could we have a test so we don't break this
> again?

Any chance you can write a test for this?

> Also, please file a bug for backport.
> Metze: Can I get some more comment from you on this?  You made
> comments
> about some of the parsing routines working only by luck here:
> https://bugzilla.samba.org/show_bug.cgi?id=12824
> Was there an intentional reason this support was lost?

Can I please get a comment on this patch from the broader team?


Andrew Bartlett
Andrew Bartlett
Authentication Developer, Samba Team         https://samba.org
Samba Development and Support, Catalyst IT   

More information about the samba-technical mailing list