[PATCH] Speed up attr_handler2 by not copying the schema

Stefan Metzmacher metze at samba.org
Thu Mar 9 07:47:22 UTC 2017


Am 09.03.2017 um 04:28 schrieb Andrew Bartlett:
> On Thu, 2017-03-09 at 12:49 +1300, Garming Sam wrote:
>> Hi metze,
>>
>> I noticed that provision is now overwhelmed with the time spent
>> schema
>> copy shallow. After looking at it more closely, the patch introducing
>> the call doesn't seem to be necessary at all. Attached is a patch to
>> remove it.
>>
> 
> Thanks Garming.  With this revised version to allow it to build with --
> picky-developer and gcc 6.3 (a const issue).
> 
> Reviewed-by: Andrew Bartlett <abartlet at samba.org>
> 
> It would be great if metze could comment, otherwise this looks like an
> easy win.

Looks like an improvement, reviewed-by me.

Thanks!
metze

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: OpenPGP digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20170309/b5bb82c1/signature.sig>


More information about the samba-technical mailing list