[PATCH] Speed up attr_handler2 by not copying the schema

Andrew Bartlett abartlet at samba.org
Thu Mar 9 03:28:51 UTC 2017


On Thu, 2017-03-09 at 12:49 +1300, Garming Sam wrote:
> Hi metze,
> 
> I noticed that provision is now overwhelmed with the time spent
> schema
> copy shallow. After looking at it more closely, the patch introducing
> the call doesn't seem to be necessary at all. Attached is a patch to
> remove it.
> 

Thanks Garming.  With this revised version to allow it to build with --
picky-developer and gcc 6.3 (a const issue).

Reviewed-by: Andrew Bartlett <abartlet at samba.org>

It would be great if metze could comment, otherwise this looks like an
easy win.

Thanks,

Andrew Bartlett
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-objectclass_attrs-Remove-schema-copy-shallow-from-at.patch
Type: text/x-patch
Size: 4579 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20170309/668d45dd/0001-objectclass_attrs-Remove-schema-copy-shallow-from-at.bin>


More information about the samba-technical mailing list