[PATCH] Speed up attr_handler2 by not copying the schema

Andreas Schneider asn at samba.org
Fri Mar 10 10:36:37 UTC 2017


On Thursday, 9 March 2017 08:47:22 CET Stefan Metzmacher wrote:
> Am 09.03.2017 um 04:28 schrieb Andrew Bartlett:
> > On Thu, 2017-03-09 at 12:49 +1300, Garming Sam wrote:
> >> Hi metze,
> >> 
> >> I noticed that provision is now overwhelmed with the time spent
> >> schema
> >> copy shallow. After looking at it more closely, the patch introducing
> >> the call doesn't seem to be necessary at all. Attached is a patch to
> >> remove it.
> > 
> > Thanks Garming.  With this revised version to allow it to build with --
> > picky-developer and gcc 6.3 (a const issue).
> > 
> > Reviewed-by: Andrew Bartlett <abartlet at samba.org>
> > 
> > It would be great if metze could comment, otherwise this looks like an
> > easy win.
> 
> Looks like an improvement, reviewed-by me.
> 
> Thanks!
> metze

RB+

Pushed to autobuild

-- 
Andreas Schneider                   GPG-ID: CC014E3D
Samba Team                             asn at samba.org
www.samba.org



More information about the samba-technical mailing list