[PATCH] samba.netbios module Python 3 compatible

Andreas Schneider asn at samba.org
Wed Jun 28 06:17:05 UTC 2017


On Tuesday, 27 June 2017 22:43:05 CEST Lumir Balhar via samba-technical wrote:
> On 06/27/2017 06:54 PM, Andrew Bartlett via samba-technical wrote:
> > On Tue, 2017-06-27 at 13:00 +0200, Lumir Balhar via samba-technical
> > 
> > wrote:
> >> Hello.
> >> 
> >> I've ported Python module samba.netbios to Python 3 compatible form.
> >> 
> >> As discussed before [0], it's really hard to write tests for modules
> >> like this because it works mostly with networks. I've tried to write
> >> some tests but I am only able test proper exceptions raising. I tested
> >> ported module manually on my LAN.
> >> 
> >> [0]
> >> https://lists.samba.org/archive/samba-technical/2017-June/120869.html
> >> and https://lists.samba.org/archive/samba-technical/2017-May/120863.html
> >> 
> >> Thank you and have a nice day.
> > 
> > Sorry, ENOPATCH :-)
> 
> Sorry, I forget to add an attachment. :-)
> 
> > We have a full emulated network in make test, so network tests should
> > be entirely practical.  Mostly just run it in an environment (rather
> > than none) and have it interrogate $SERVER from the environment.
> 
> Could you please show me some example of tests which use emulated
> network? Or create one for samba.netbios which I can use as an example?

If you reach me over internal IRC or just call my internal number we can have 
a share screen session and I explain you our awesome test environment ;)


	Andreas

-- 
Andreas Schneider                   GPG-ID: CC014E3D
Samba Team                             asn at samba.org
www.samba.org



More information about the samba-technical mailing list