[PATCH] samba.netbios module Python 3 compatible

[Lumir Balhar]

On 06/27/2017 06:54 PM, Andrew Bartlett via samba-technical wrote:
> On Tue, 2017-06-27 at 13:00 +0200, Lumir Balhar via samba-technical
> wrote:
>> Hello.
>>
>> I've ported Python module samba.netbios to Python 3 compatible form.
>>
>> As discussed before [0], it's really hard to write tests for modules
>> like this because it works mostly with networks. I've tried to write
>> some tests but I am only able test proper exceptions raising. I tested
>> ported module manually on my LAN.
>>
>> [0]
>> https://lists.samba.org/archive/samba-technical/2017-June/120869.html
>> and https://lists.samba.org/archive/samba-technical/2017-May/120863.html
>>
>> Thank you and have a nice day.
> Sorry, ENOPATCH :-)
Sorry, I forget to add an attachment. :-)
>
> We have a full emulated network in make test, so network tests should
> be entirely practical.  Mostly just run it in an environment (rather
> than none) and have it interrogate $SERVER from the environment.
Could you please show me some example of tests which use emulated 
network? Or create one for samba.netbios which I can use as an example?
>
> Thanks,
>
> Andrew Bartlett
>
Thank you!
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-python-tests-Add-a-few-tests-for-samba.netbios-modul.patch
Type: text/x-patch
Size: 2757 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20170627/ccb764a6/0002-python-tests-Add-a-few-tests-for-samba.netbios-modul.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-python-Port-samba.netbios-module-to-Python-3-compati.patch
Type: text/x-patch
Size: 7408 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20170627/ccb764a6/0001-python-Port-samba.netbios-module-to-Python-3-compati.bin>