CTDB ipreallocated event handling
martin at meltin.net
Thu Jul 13 05:30:33 UTC 2017
On Wed, 12 Jul 2017 13:28:13 +0200, Bjoern Baumbach <bb at sernet.de>
> thank you very much for the explanation and updating the docs!
> On 07/12/2017 04:40 AM, Martin Schwenke wrote:
> > The documentation was out of date.
> > Now that service_check_reconfigure() is gone, we check
> > ctdb_service_needs_reconfigure() explicitly in the "ipreallocated"
> > event and run ctdb_service_reconfigure(), which we still have
> > because it does a bit of magic that we don't quite want to get rid
> > of without thinking carefully.
> This was a good decision. Handling the changes in the "ipreallocated"
> event is much more comprehensible :-)
> The updated documentation looks much better.
> Adding the "updateip" event to the following part might help some
> users, who like to implement their own event scripts:
> -* An event script can use ctdb_service_set_reconfigure() in "takeip"
> - or "releaseip" events to flag that its service needs to be
> +* An event script can use ctdb_service_set_reconfigure() in "takeip",
> + "releaseip" or "updateip" events to flag that its service needs to
> be reconfigured. The "ipreallocated" event can then use
Are you happy for me to squash that change in with my patch and re-post?
peace & happiness,
More information about the samba-technical