CTDB ipreallocated event handling

[Martin Schwenke]

On Thu, 13 Jul 2017 15:30:33 +1000, Martin Schwenke via samba-technical
<samba-technical at lists.samba.org> wrote:

> On Wed, 12 Jul 2017 13:28:13 +0200, Bjoern Baumbach <bb at sernet.de>
> wrote:
> 
> > thank you very much for the explanation and updating the docs!
> > 
> > On 07/12/2017 04:40 AM, Martin Schwenke wrote:  
> > > The documentation was out of date.
> > > 
> > > Now that service_check_reconfigure() is gone, we check
> > > ctdb_service_needs_reconfigure() explicitly in the "ipreallocated"
> > > event and run ctdb_service_reconfigure(), which we still have
> > > because it does a bit of magic that we don't quite want to get rid
> > > of without thinking carefully.    
> > 
> > This was a good decision. Handling the changes in the "ipreallocated"
> > event is much more comprehensible :-)
> > 
> > The updated documentation looks much better.  
> 
> Yay!  :-)
> 
> > Adding the "updateip" event to the following part might help some
> > users, who like to implement their own event scripts:
> > 
> > -* An event script can use ctdb_service_set_reconfigure() in "takeip"
> > -  or "releaseip" events to flag that its service needs to be
> > +* An event script can use ctdb_service_set_reconfigure() in "takeip",
> > +  "releaseip" or "updateip" events to flag that its service needs to
> > be reconfigured. The "ipreallocated" event can then use  
> 
> Are you happy for me to squash that change in with my patch and re-post?

Assuming the answer to this is "yes", so updated patch is attached.  :-)

Please review and maybe push...

peace & happiness,
martin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-ctdb-docs-Update-documentation-of-ipreallocated-even.patch
Type: text/x-patch
Size: 2918 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20170713/f84969e7/0001-ctdb-docs-Update-documentation-of-ipreallocated-even.bin>