[PATCHS] make pthreadpool common

Matthieu Patou mat at matws.net
Thu Feb 9 19:16:20 UTC 2017

On 02/09/2017 12:26 AM, Volker Lendecke wrote:
> On Wed, Feb 08, 2017 at 02:46:55PM -0800, Matthieu Patou wrote:
>> We discussed this last week, there is a great piece of work in
>> source3/lib/pthreadpool and it just seems that it could be used by more
>> components than winbindd and the file server. So I'm proposing with
>> those patches to move it to the top of tree.
>> I did a build and also autobuild (which failed after 2h5 minutes in some
>> AD DC DNS related tests, so I don't think it related to my change).
>> Please review !
> I'd like the comment in the last patch to slightly change: I don't think
> that it is a requirement for the usability of some component to live
> in the toplevel. I'd have to look, but I'm 100% certain we have
> toplevel and/or AD DC components depending on code in source3 and we
> have compontents in source3 that depend on code in source4. So this is
> a purely cosmetic change.
Agreed, what I meant is that if it's at the top of the tree it makes it
more obvious that it can used different contexts.


More information about the samba-technical mailing list