[PATCHS] make pthreadpool common

Jeremy Allison jra at samba.org
Thu Feb 9 18:49:49 UTC 2017

On Thu, Feb 09, 2017 at 09:26:26AM +0100, Volker Lendecke wrote:
> On Wed, Feb 08, 2017 at 02:46:55PM -0800, Matthieu Patou wrote:
> > 
> > We discussed this last week, there is a great piece of work in
> > source3/lib/pthreadpool and it just seems that it could be used by more
> > components than winbindd and the file server. So I'm proposing with
> > those patches to move it to the top of tree.
> > 
> > I did a build and also autobuild (which failed after 2h5 minutes in some
> > AD DC DNS related tests, so I don't think it related to my change).
> > 
> > 
> > Please review !
> I'd like the comment in the last patch to slightly change: I don't think
> that it is a requirement for the usability of some component to live
> in the toplevel. I'd have to look, but I'm 100% certain we have
> toplevel and/or AD DC components depending on code in source3 and we
> have compontents in source3 that depend on code in source4. So this is
> a purely cosmetic change.

Pushed, after changing the comment to : "Move pthreadpool to top of the tree."

I agree this is comsmetic, but it really does help to re-arrange
the code in this way.

New programmers to Samba will now easily understand that the
pthreadpool implementation is a generic component we should
encourage use of in new code, not a smbd/Samba3-subsystem
specific library.

It does (IMHO) make our codebase a lot more friendly for
new developers to understand.


More information about the samba-technical mailing list