Latest AV code
Ralph Böhme
slow at samba.org
Tue Dec 26 14:19:19 UTC 2017
On Tue, Dec 26, 2017 at 03:11:56AM -0700, Trever L. Adams wrote:
> In the actual scanner modules, there is a lot of
>
> if (stringfunction){
>
> } else if (stringfunction) {
>
> } else if (stringfunction) {
>
> }
>
> The logic is fairly clear as written and would be very difficult to make
> sense if one must capture the return and use that in the if/else if.
Fmpov: leave these as is. There are two possible reasons for not doing function
calls in compound statements: eases debugging and easier to read. Neither holds
in this case.
-slow
--
Ralph Boehme, Samba Team https://samba.org/
Samba Developer, SerNet GmbH https://sernet.de/en/samba/
More information about the samba-technical
mailing list