Latest AV code

Trever L. Adams trever at middleearth.sapphiresunday.org
Tue Dec 26 10:11:56 UTC 2017


On 12/25/2017 10:51 AM, Trever L. Adams wrote:
>
> Jeremy and Ralph, some of what is below may have existed prior to the
> refactoring. I will get back to you in a day or two as noted below.
>
>
>     /*
>      * Check quarantine directory now to save processing
>      * and becoming root over and over.
>      */
>
> Which is around line 373 in vfs_virusfilter.c is incorrect. The
> directory cannot be created ahead of time, if I understanding the
> BackupIntent opens change correctly, the quarantine directory must be in
> the same level or lower (a/b/c/ or a/b/c/d/e not a/b) as the file in
> question. I would like to remove this. Is every one okay with this?
>
> There is a new null deference problem in the config param for the
> communications sockect. I have fixed this. The lp_* function for that
> parameter was called twice, invalidating some of the necessary checks. I
> have fixed this. scan on open is supposed to default true. In the change
> it was set to false. I have fixed this.
>
> I am going to need another day or two to fully test the code with
> clamav, to do the coding style fixups and to make sure that everything
> matches the man page defaults.
>
> Thank you,
> Trever
>
In the actual scanner modules, there is a lot of

if (stringfunction){

} else if (stringfunction) {

} else if (stringfunction) {

}

The logic is fairly clear as written and would be very difficult to make
sense if one must capture the return and use that in the if/else if.

As this is protocol talking/checking is it possible to leave as is? I
believe it was previously decided by someone that it was, but if not I
will try to figure things out. Other than that, I have some testing to
do and I can provide updated patches.

Thank you.

Trever


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 886 bytes
Desc: OpenPGP digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20171226/b4fdfe0e/signature.sig>


More information about the samba-technical mailing list