Latest AV code

[Trever L. Adams]

On 12/26/2017 07:19 AM, Ralph Böhme wrote:
> On Tue, Dec 26, 2017 at 03:11:56AM -0700, Trever L. Adams wrote:
>> In the actual scanner modules, there is a lot of
>>
>> if (stringfunction){
>>
>> } else if (stringfunction) {
>>
>> } else if (stringfunction) {
>>
>> }
>>
>> The logic is fairly clear as written and would be very difficult to make
>> sense if one must capture the return and use that in the if/else if.
> Fmpov: leave these as is. There are two possible reasons for not doing function
> calls in compound statements: eases debugging and easier to read. Neither holds
> in this case.
>
> -slow
>
Thank you Ralph. Attached is the unsquashed patch relative to your work.
I am providing it as I would appreciate another set of eyes to make sure
my changes enhance readability, debug-ability and maintainability. I
also need help to make sure I haven't accidentally inverted logic before
I squash it into the appropriate patches. I need this as it is not
possible for me to test all possible combinations/functionality at this
time.

Outstanding for me to do:

* Recheck quarantine (my installations tend to be rename only)

* Recheck streams (not normally used in my installation)

* Address issue brought up before being the code and comment mentioned
below:

    /*
     * Check quarantine directory now to save processing
     * and becoming root over and over.
     */

Which is around line 373 in vfs_virusfilter.c is incorrect. The
directory cannot be created ahead of time, if I understanding the
BackupIntent opens change correctly, the quarantine directory must be in
the same level or lower (a/b/c/ or a/b/c/d/e not a/b) as the file in
question. I would like to remove this. Is every one okay with this?

With assistance on the last, I should be finished with testing some time
tomorrow.

Thank you.
Trever
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Better-follow-Samba-coding-style.patch
Type: text/x-patch
Size: 37712 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20171226/77317a21/0001-Better-follow-Samba-coding-style.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 886 bytes
Desc: OpenPGP digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20171226/77317a21/signature.sig>