[PATCH] Fix 'net ads changetrustpw'

Rowland Penny rpenny at samba.org
Thu Aug 10 13:06:40 UTC 2017

On Thu, 10 Aug 2017 14:49:04 +0200
Andreas Schneider <asn at samba.org> wrote:

> On Thursday, 10 August 2017 10:20:41 CEST Rowland Penny via
> samba-technical wrote:
> > Yes, but where do I stop ?
> > Have you ever run any of the test sh scripts through shellcheck ?
> > 
> > It also sort of backs up up what Andrew has been saying lately,
> > people will just cut and paste bad code.
> > It wouldn't be allowed in a python, so why in sh ?
> I think the shell scripts need a cleanup alltogether and we should
> have much more common function which are shared. Someone needs to
> start. Maybe $() is a start ...
> The problem is time. We do not have the resources to rework all of
> that. Normally I try to do it when I write new stuff.
> 	Andreas

Time is what I have a lot of ;-)

Okay, stand by for a deluge as I run every 'sh' script through


More information about the samba-technical mailing list