[PATCH] Fix 'net ads changetrustpw'
realrichardsharpe at gmail.com
Fri Aug 11 00:06:15 UTC 2017
On Wed, Aug 9, 2017 at 9:45 AM, Andreas Schneider via samba-technical
<samba-technical at lists.samba.org> wrote:
> as always, untested code is broken code. So I broke 'net ads changetrustpw' in
> Samba 4.6.
> The attached patch fixes the issue and adds a tests which verifies that it is
> Please review and push if OK.
I have a couple of questions. While it looks OK,
1. I can't see why you changed princ to NULL in the following:
ret = krb5_set_password(context,
Perhaps it's because we just got a changepw ticket for the princ, so
it is established in the creds who we are changing the password for.
2. Can you fix the indentation in the call to krb5_set_password?
Other than that, I think the backticks are fine until someone changes
them all to bash style $(...) for all tests.
So, conditional RB+ by me.
More information about the samba-technical