[PATCH] Fix 'net ads changetrustpw'
asn at samba.org
Thu Aug 10 12:49:04 UTC 2017
On Thursday, 10 August 2017 10:20:41 CEST Rowland Penny via samba-technical
> Yes, but where do I stop ?
> Have you ever run any of the test sh scripts through shellcheck ?
> It also sort of backs up up what Andrew has been saying lately, people
> will just cut and paste bad code.
> It wouldn't be allowed in a python, so why in sh ?
I think the shell scripts need a cleanup alltogether and we should have much
more common function which are shared. Someone needs to start. Maybe $() is a
The problem is time. We do not have the resources to rework all of that.
Normally I try to do it when I write new stuff.
Andreas Schneider GPG-ID: CC014E3D
Samba Team asn at samba.org
More information about the samba-technical