Please use "error and out" logic (Re: [PATCH] Avoid privileged segfault in GetNCChanges and add many more tests)

Stefan Metzmacher metze at
Thu Aug 10 11:31:46 UTC 2017

Am 10.08.2017 um 13:14 schrieb Andrew Bartlett:
> On Thu, 2017-08-10 at 13:04 +0200, Stefan Metzmacher wrote:
>> Hi Andrew,
>> here's my version with some comments in it.
> Thanks,  I'll look at that next week (this 'simple fix' for the
> bugzilla bug kind of ballooned!). 
>> In general please check if we need the BUG: line
>> in every commit, and move commits without towards the end of the
>> patchset. 
> The only commit needing the BUG is the one I tagged.  The rest is just
> for master, to prove we don't regress in the future. 

Ok, then I may already push some of the good once, which are independent.

>> (The BUG: line should be before the Signed-off-by: line
>> followed by an empty line...)
> I don't mind some rules, but where did this one come from?

It's just the way a few thousand other commits look like.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: OpenPGP digital signature
URL: <>

More information about the samba-technical mailing list