Please use "error and out" logic (Re: [PATCH] Avoid privileged segfault in GetNCChanges and add many more tests)

Andrew Bartlett abartlet at
Thu Aug 10 11:14:57 UTC 2017

On Thu, 2017-08-10 at 13:04 +0200, Stefan Metzmacher wrote:
> Hi Andrew,
> here's my version with some comments in it.

Thanks,  I'll look at that next week (this 'simple fix' for the
bugzilla bug kind of ballooned!). 

> In general please check if we need the BUG: line
> in every commit, and move commits without towards the end of the
> patchset. 

The only commit needing the BUG is the one I tagged.  The rest is just
for master, to prove we don't regress in the future. 

> (The BUG: line should be before the Signed-off-by: line
> followed by an empty line...)

I don't mind some rules, but where did this one come from?

(I often add the BUG: tag with a script, which is why they end up


Andrew Bartlett
Andrew Bartlett             
Authentication Developer, Samba Team
Samba Developer, Catalyst IT

More information about the samba-technical mailing list