Please use "error and out" logic (Re: [PATCH] Avoid privileged segfault in GetNCChanges and add many more tests)

Andrew Bartlett abartlet at
Mon Aug 14 07:20:21 UTC 2017

On Thu, 2017-08-10 at 13:04 +0200, Stefan Metzmacher wrote:
> Hi Andrew,
> here's my version with some comments in it.
> In general please check if we need the BUG: line
> in every commit, and move commits without towards the end of the
> patchset. (The BUG: line should be before the Signed-off-by: line
> followed by an empty line...)
> metze


> Subject: [PATCH 05/10] TODO: s4-drsuapi: Refuse to replicate an NC is that not
>  actually an NC
> This prevents replication of an OU, you must replicate a whole NC per Windows 2012R2
> Signed-off-by: Andrew Bartlett <abartlet at>
> TODO: shouldn't we use dsdb_search_one()?

No, I think dsdb_search_dn() is correct, as used often elsewhere.  We
could remove the check of count > 1, we can't get that unless we have
DB corruption, but we of course just had that...

I'm heads-down in the binary index work, but I'm grateful to Tim who
will tidy this up for us, so you can expect to see an improved set of
patches soon. 


Andrew Bartlett

Andrew Bartlett             
Authentication Developer, Samba Team
Samba Developer, Catalyst IT

More information about the samba-technical mailing list