[PATCH] remove early check for saltPrincipal in smb_krb5_update_keytab

Garming Sam garming at catalyst.net.nz
Thu Sep 8 20:56:42 UTC 2016


On 08/09/16 17:39, Andreas Schneider wrote:
> Shouldn't the code call smb_krb5_remove_obsolete_keytab_entries() directly 
> instead of smb_krb5_update_keytab() if we only want to delete objects?
>

In which case, we'd need to duplicate the setup in
smb_krb5_update_keytab (for getting the keytab and principals) and make
a new utility function to only be called once. It's more effort for
little gain.


Cheers,

Garming



More information about the samba-technical mailing list