[PATCH] remove early check for saltPrincipal in smb_krb5_update_keytab

Andreas Schneider asn at samba.org
Thu Sep 8 05:39:38 UTC 2016


On Thursday, 8 September 2016 12:18:11 CEST Garming Sam wrote:
> I agree that we need to figure out some kind of general upgrade path.
> But I would've thought that this patch would be necessary regardless.
> It's not removing the check for the saltPrincipal, only deferring it
> until it needs to be used in that function. Otherwise it is just
> arbitrarily blocking deletions of something knowingly corrupt or
> incomplete.

So the codepath wants to trigger smb_krb5_remove_obsolete_keytab_entries() and 
calls smb_krb5_update_keytab() for that.

Shouldn't the code call smb_krb5_remove_obsolete_keytab_entries() directly 
instead of smb_krb5_update_keytab() if we only want to delete objects?


Cheers,


	-- andreas


-- 
Andreas Schneider                   GPG-ID: CC014E3D
Samba Team                             asn at samba.org
www.samba.org



More information about the samba-technical mailing list