[PATCH] remove early check for saltPrincipal in smb_krb5_update_keytab
Andreas Schneider
asn at samba.org
Fri Sep 9 05:41:22 UTC 2016
On Friday, 9 September 2016 08:56:42 CEST Garming Sam wrote:
> On 08/09/16 17:39, Andreas Schneider wrote:
> > Shouldn't the code call smb_krb5_remove_obsolete_keytab_entries() directly
> > instead of smb_krb5_update_keytab() if we only want to delete objects?
>
> In which case, we'd need to duplicate the setup in
> smb_krb5_update_keytab (for getting the keytab and principals) and make
> a new utility function to only be called once. It's more effort for
> little gain.
I'm fine with the patch if you write doxygen documentation for the function
documenting the behavior :-)
-- andreas
--
Andreas Schneider GPG-ID: CC014E3D
Samba Team asn at samba.org
www.samba.org
More information about the samba-technical
mailing list