[PATCH] ldb_controls: avoid unnecessary unchecked talloc_asprintf()s

Andrew Bartlett abartlet at samba.org
Tue Mar 22 21:31:16 UTC 2016

On Tue, 2016-03-22 at 14:19 +1300, Douglas Bagnall wrote:
> While I was looking through lib/ldb/common/ldb_controls.c for memory
> allocations lacking ldb_oom() I found lots of seemingly pointless
> talloc_asprintf()ing. Removing these doesn't really save us from
> unchecked memory errors, as ldb_set_errstring() does asprintf()
> anyway, but it kind of kicks the problem along a little bit.

Thanks Douglas,

I reviewed and auto-built this yesterday, along with the VLV work!

Andrew Bartlett

Andrew Bartlett
Authentication Developer, Samba Team         https://samba.org
Samba Development and Support, Catalyst IT   

More information about the samba-technical mailing list