[PATCH] ldb_controls: avoid unnecessary unchecked talloc_asprintf()s

Douglas Bagnall douglas.bagnall at catalyst.net.nz
Tue Mar 22 01:19:09 UTC 2016


While I was looking through lib/ldb/common/ldb_controls.c for memory
allocations lacking ldb_oom() I found lots of seemingly pointless
talloc_asprintf()ing. Removing these doesn't really save us from
unchecked memory errors, as ldb_set_errstring() does asprintf()
anyway, but it kind of kicks the problem along a little bit.

Douglas
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-ldb_controls-avoid-unnecessary-unchecked-talloc_aspr.patch
Type: text/x-diff
Size: 20584 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20160322/c28d815f/0001-ldb_controls-avoid-unnecessary-unchecked-talloc_aspr.diff>


More information about the samba-technical mailing list