[PATCH] ldb_controls: avoid unnecessary unchecked talloc_asprintf()s

[Stefan Metzmacher]

Hi Douglas,

> I reviewed and auto-built this yesterday, along with the VLV work!

Can you have a look at this build failure, please?

http://git.samba.org/autobuild.flakey.sn-devel-104/2016-03-22-2007/samba.stderr

[1902/4035] Compiling source4/dsdb/samdb/ldb_modules/vlv_pagination.c
cc1: warnings being treated as errors
../source4/dsdb/samdb/ldb_modules/vlv_pagination.c: In function
'vlv_results':
../source4/dsdb/samdb/ldb_modules/vlv_pagination.c:335: error:
declaration of 'index' shadows a global declaration
/usr/include/string.h:487: error: shadowed declaration is here
Waf: Leaving directory `/memdisk/autobuild/fl/b2864160/samba/bin'
Build failed:  -> task failed (err #1):
	{task: cc vlv_pagination.c -> vlv_pagination_90.o}
make: *** [all] Error 1

Thanks!
metze

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: OpenPGP digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20160322/4e3209ab/signature.sig>