[PATCHESv3]vfs: separate fs stats from quota in vfs modules

Uri Simchoni uri at samba.org
Thu Jan 21 11:47:29 UTC 2016

On 01/21/2016 12:50 PM, Volker Lendecke wrote:
> On Wed, Jan 20, 2016 at 12:13:58AM +0200, Uri Simchoni wrote:
>> Thanks for looking into this!
>> Attached is v3 of the patchset. Relative to v2:
>> - Patch 1/15 fixed if{} style in loadparm change
>> - Patch 4/15 - make the module build only in developer mode, and fix
>> True->true, False->false
> Sorry to be picky, but there's still at least two
>                  if (D.softlimit == 0)
>                          D.softlimit = D.hardlimit;
> without {}.
> We've had pretty bad bugs due to changes in if-statements
> that forgot to add {} when adding lines. Apple's "goto fail"
> bug is not 100% the same, but in the very same category of
> what can happen here.
> Volker
Not at all picky, and sorry for not spotting this (I was looking at the 
patches and not at the code - this is part of the original code but 
should be fixed while we're at it). I'll post a fix later today.


More information about the samba-technical mailing list