[PATCHESv4]vfs: separate fs stats from quota in vfs modules

Uri Simchoni uri at samba.org
Thu Jan 21 19:36:00 UTC 2016


OK I hope I got that finally cleaned up.
- cleaned the braces style in patch #4
- added style cleanup for disk_quotas as additional patch #16

Sorry for wasting your time with {} issues.
Thanks,
Uri.

On 01/21/2016 01:47 PM, Uri Simchoni wrote:
>
>
> On 01/21/2016 12:50 PM, Volker Lendecke wrote:
>> Sorry to be picky, but there's still at least two
>>
>>                  if (D.softlimit == 0)
>>                          D.softlimit = D.hardlimit;
>>
>> without {}.
>>
>> We've had pretty bad bugs due to changes in if-statements
>> that forgot to add {} when adding lines. Apple's "goto fail"
>> bug is not 100% the same, but in the very same category of
>> what can happen here.
>>
>> Volker
>>
> Not at all picky, and sorry for not spotting this (I was looking at 
> the patches and not at the code - this is part of the original code 
> but should be fixed while we're at it). I'll post a fix later today.
>
> Thanks!
> Uri.
>




More information about the samba-technical mailing list