[PATCHESv3]vfs: separate fs stats from quota in vfs modules

Volker Lendecke Volker.Lendecke at SerNet.DE
Thu Jan 21 10:50:37 UTC 2016

On Wed, Jan 20, 2016 at 12:13:58AM +0200, Uri Simchoni wrote:
> Thanks for looking into this!
> Attached is v3 of the patchset. Relative to v2:
> - Patch 1/15 fixed if{} style in loadparm change
> - Patch 4/15 - make the module build only in developer mode, and fix
> True->true, False->false

Sorry to be picky, but there's still at least two

                if (D.softlimit == 0)
                        D.softlimit = D.hardlimit;

without {}.

We've had pretty bad bugs due to changes in if-statements
that forgot to add {} when adding lines. Apple's "goto fail"
bug is not 100% the same, but in the very same category of
what can happen here.


SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:kontakt at sernet.de

More information about the samba-technical mailing list