[PATCH] Enhance time sampling of async IO VFS functions

Volker Lendecke Volker.Lendecke at SerNet.DE
Sun Feb 28 16:45:24 UTC 2016


On Sun, Feb 28, 2016 at 08:39:19AM -0800, Jeremy Allison wrote:
> > Is it theoretically possible to implement this feature without modifying
> > tevent, just within asys.c? Apologies for not coming up with a polished
> > proposal mself, but I would like to avoid bloat in such a central
> > structure if possible.
> 
> Sure, if we change the param blocks to the smbd VFS aio
> calls then we can do it only inside smbd.
> 
> I think the question Ralph had is more about if you
> think this is worthwhile to add as a feature to tevent ?
> 
> Or did you just answer that question ? :-) :-).

Right now we have one case where someone really needs this feature. We
have many cases that don't. So if there's an elegant way to do this
without adding 8 bytes to struct tevent_req I'd prefer that.

Volker

-- 
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:kontakt at sernet.de



More information about the samba-technical mailing list